Skip to content

libretro: Add GET_CORE_DATA and SET_CORE_DATA environment callbacks#17012

Open
RobLoach wants to merge 5 commits intolibretro:masterfrom
RobLoach:core_data
Open

libretro: Add GET_CORE_DATA and SET_CORE_DATA environment callbacks#17012
RobLoach wants to merge 5 commits intolibretro:masterfrom
RobLoach:core_data

Conversation

@RobLoach
Copy link
Copy Markdown
Member

@RobLoach RobLoach commented Sep 17, 2024 •
edited
Loading

This introduces two environment callbacks that allow setting a user data pointer for arbitrary core data. This is one step closer to allowing cores to avoid declaring their own global/static variables, or playing around with threads to determine their own local state.

Example in libretro-samples: libretro/libretro-samples#30

typedef struct core_data_t {
    int lives;
} core_data_t;

// Set the core data
core_data_t* data = calloc(1, sizeof(core_data_t));
data->lives = 5;
environ_cb(RETRO_ENVIRONMENT_SET_CORE_DATA, data);

// Get the core data
core_data_t* data = NULL;
environ_cb(RETRO_ENVIRONMENT_GET_CORE_DATA, &data);
int lives = core->lives;

@RobLoach RobLoach mentioned this pull request Sep 17, 2024
Draft
@RobLoach RobLoach changed the title libretro: Add RETRO_ENVIRONMENT_GET_CORE_DATA and RETRO_ENVIRONMENT_SET_CORE_DATA libretro: Add RETRO_ENVIRONMENT_GET_CORE_DATA and RETRO_ENVIRONMENT_SET_CORE_DATA Sep 17, 2024
@RobLoach RobLoach changed the title libretro: Add RETRO_ENVIRONMENT_GET_CORE_DATA and RETRO_ENVIRONMENT_SET_CORE_DATA libretro: Add GET_CORE_DATA and SET_CORE_DATA environment callbacks Sep 17, 2024
JesseTG
JesseTG reviewed Sep 17, 2024
View reviewed changes
Comment thread libretro-common/include/libretro.h
@ghost
Copy link
Copy Markdown

ghost commented Nov 13, 2024

About time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JesseTG JesseTG JesseTG left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@RobLoach @JesseTG